On Thu, 17 Jun 2021 12:39:17 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> src/java.base/unix/native/libnet/PlainDatagramSocketImpl.c line 2112: >> >>> 2110: res = setsockopt(fd, IPPROTO_IPV6, (join ? ADD_MEMBERSHIP : >>> DRP_MEMBERSHIP), >>> 2111: (char *) &mname6, sizeof (mname6)); >>> 2112: >> >> Seems to be an extraneous space after sizeof here. > > A general question. Is "__APPLE__" the preferred macro name or MACOSX? Not a > big deal but MACOSX looks slightly more common. [Seems github has removed the > underscores from APPLE] thanks ... I'll attend to the spacing I used __APPLE__ as it was already in place for a change to set socket buffer size ------------- PR: https://git.openjdk.java.net/jdk17/pull/44
