On Thu, 17 Jun 2021 16:23:08 GMT, Mahendra Chhipa <github.com+34924738+mahendrachh...@openjdk.org> wrote:
>> …HttpCallback from open/test/jdk/sun/net/www/protocol/https/ tests > > Mahendra Chhipa has updated the pull request incrementally with one > additional commit since the last revision: > > Implemented review comments test/jdk/sun/net/www/protocol/https/ChunkedOutputStream.java line 89: > 87: return hostaddr + ":" + server.getAddress().getPort(); > 88: } > 89: public void handle(HttpExchange req) throws IOException { Minor style point. I would put a blank line between the two methods. test/jdk/sun/net/www/protocol/https/ChunkedOutputStream.java line 170: > 168: req.sendResponseHeaders(404, -1); > 169: break; > 170: } Probably should add a call to "req.close()" at the end of the method. test/jdk/sun/net/www/protocol/https/ChunkedOutputStream.java line 366: > 364: TrustManagerFactory tmf = > TrustManagerFactory.getInstance("SunX509"); > 365: tmf.init(ts); > 366: Could SimpleSSLContext be used here instead of manually writing this code? Same for other tests with same pattern. ------------- PR: https://git.openjdk.java.net/jdk/pull/4432