On Wed, 23 Jun 2021 18:02:02 GMT, Julia Boes <jb...@openjdk.org> wrote:

>> `com.sun.net.httpserver.Headers` normalizes its keys to adhere to the 
>> following format: First character uppercase, all other characters lowercase, 
>> for example `"foo" -> "Foo"`. This behaviour is not consistent across the 
>> mutator methods of the class, in particular `putAll()` and `replaceAll()` do 
>> not apply normalization.
>> 
>> The suggested fix is to update the implementation of `putAll()` and to add 
>> an implementation of of the java.util.Map default method `replaceAll()`. 
>> While here, we can improve `equals()` by adding a type check and add a 
>> `toString()` implementation.
>> 
>> Additionally,  the Headers class is updated to disallow null values for keys 
>> and values.
>
> Julia Boes has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   confirm HttpExchange::sendResponseHeaders fails if key/value null

Marked as reviewed by chegar (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4528

Reply via email to