On Tue, 29 Jun 2021 16:06:52 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/SctpChannelImpl.java line 643: >> >>> 641: if (state == ChannelState.UNINITIALIZED) { >>> 642: SctpNet.close(fdVal); >>> 643: state = ChannelState.KILLED; >> >> It might be better to invert these, meaning set the state to KILLED before >> close(fdVal), just in case the close throws. > > So modified. It looks like you've changed some but not all cases. I realize ChannelState.UNINITIALIZED is not too interesting but further maintainers may wonder about it. ------------- PR: https://git.openjdk.java.net/jdk/pull/4621