On Mon, 11 Oct 2021 09:42:12 GMT, Patrick Concannon <pconcan...@openjdk.org> wrote:
> Hi, > > Could someone please review my changes (and CSR) to drop support for pre JDK > 1.4 `DatagramSocketImpl` implementations? > > These changes propose to drop support for `DatagramSocketImpls` that were > compiled with JDK 1.3 or older, which do not have support for connected > sockets, for peeking at received datagrams, and for joining and leaving a > group at a specific interface. This support is legacy, and should be > relatively safe to remove as such implementations do not compile with JDK 1.4 > or newer. > > Finally, with this set of proposed changes, if you have an `oldImpl`, and > don’t use connect, then the methods `joinGroup` and `leaveGroup` will throw > `NoSuchMethodError`. However, the current behaviour in `DatagramSocketImpl` > is to throw an `UnsupportedOperationsException` for a method not implemented. > Should this set of changes update the `joinGroup` and `leaveGroup` methods in > order to preserve this behaviour? > > CSR: https://bugs.openjdk.java.net/browse/JDK-8274633 > > Kind regards, > > Patrick src/java.base/share/classes/java/net/DatagramSocketImpl.java line 105: > 103: * > 104: * @implSpec the default implementation of this method always throws > {@code SocketException} > 105: * The implementation change looks fine. For the implSpec then it might be simpler if you drop "always" from the sentence. Also minor nit is that you use "the default" in connect vs. "The default" in disconnect. ------------- PR: https://git.openjdk.java.net/jdk/pull/5887
