On Mon, 22 Nov 2021 09:43:19 GMT, Julia Boes <jb...@openjdk.org> wrote:

> This change introduces jwebserver, a dedicated JDK tool for the Simple Web 
> Server. 
> 
> A description is provided in a follow-up comment.

Build changes look good.

src/jdk.httpserver/share/classes/sun/net/httpserver/simpleserver/JWebServer.java
 line 60:

> 58:     public static void main(String... args) {
> 59:         int ec = SimpleFileServerImpl.start(new PrintWriter(System.out, 
> true, UTF_8), "jwebserver", args);
> 60:         if (ec != 0)

Personally I strongly dislike multiline if-statements without braces. They are 
an invitation to mistakes. Please reconsider putting this on one line, or 
adding braces.

-------------

PR: https://git.openjdk.java.net/jdk/pull/6497

Reply via email to