On Fri, 11 Mar 2022 17:37:44 GMT, Michael McMahon <micha...@openjdk.org> wrote:
>> Hi, >> >> Could I get the following change reviewed please, which is to disable the >> MD5 message digest algorithm by default in the HTTP Digest authentication >> mechanism? The algorithm can be opted into by setting a new system property >> "http.auth.digest.reEnabledAlgs" to include the value MD5. The change also >> updates the Digest authentication implementation to use some of the more >> secure features defined in RFC7616, such as username hashing and additional >> digest algorithms like SHA256 and SHA512-256. >> >> - Michael > > Michael McMahon has updated the pull request incrementally with one > additional commit since the last revision: > > update after second review round src/java.base/share/classes/sun/net/www/protocol/http/DigestAuthentication.java line 102: > 100: propPrefix + "reEnabledAlgorithms"; > 101: > 102: private static final Set<String> disabledAlgorithms = new > HashSet<>(); It would be much better if this was an immutable set to make it MT-safe. You could set the value in the static block below using Set.copyOf(). ------------- PR: https://git.openjdk.java.net/jdk/pull/7688
