On Thu, 24 Mar 2022 18:21:45 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> Conor Cleary has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8263031: further verification of push promise and response
>> - 8263031: Removed duplicate import
>
> src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java
> line 807:
>
>> 805: } catch (UncheckedIOException e) {
>> 806: debug.log("Error handling Push Promise with
>> Continuation: " + e.getMessage(), e);
>> 807: protocolError(ResetFrame.PROTOCOL_ERROR,
>> e.getMessage());
>
> I believe it would more clear to use `ErrorFrame.PROTOCOL_ERROR` or
> `GoAwayFrame.PROTOCOL_ERRROR` here and in the other calls to protocolError
> below, since we're not resetting the stream here but closing the whole
> connection with a `GoAwayFrame`.
Oh yes, good point. I think `ErrorFrame.PROTOCOL_ERROR` would be the most
appropriate here. I'll amend the change accordingly.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7696
