On Thu, 7 Apr 2022 13:53:35 GMT, Conor Cleary <ccle...@openjdk.org> wrote:
>> **Issue** >> When using the `HttpClient.send()` to send a GET request created using the >> `HttpRequest.newBuilder()`, a `Content-length: 0` header is set. This >> behaviour causes issues with many services as a body related header is >> usually not expected to be included with a GET request. >> >> **Solution** >> `Http1Request.java` was modified so that when the request method is a GET, a >> `Content-length` header is not added to the request. However, if a developer >> chooses to include a body in a GET request (though it is generally >> considered bad practice), a `Content-length` header with the appropriate >> value will be added. > > Conor Cleary has updated the pull request incrementally with one additional > commit since the last revision: > > 8283544: Updated URI creation @Michael-Mc-Mahon @djelinski @jaikiran the src/ and test/ changes have been updated with reference to your comments. Seeking additional feedback if there is any? Also thanks for the previous reviews, all been very helpful! ------------- PR: https://git.openjdk.java.net/jdk/pull/8017
