On Wed, 12 Oct 2022 14:23:13 GMT, Daniel Fuchs <dfu...@openjdk.org> wrote:
>> When [JDK-8277969](https://bugs.openjdk.org/browse/JDK-8277969) was >> implemented, a list of outstanding response subscribers was added to >> `HttpClientImpl`. A body subscriber is added to the list after being created >> and is removed from the list when it is completed, either successfully or >> exceptionally. >> >> It appears that in the case where the subscription is cancelled before the >> subscriber is completed, the subscriber might remain registered in the list >> forever, or at least until the HttpClient gets garbage collected. This can >> be easily reproduced using streaming subscribers, such as >> BodySubscriber::ofInputStream. In the case where the input stream is closed >> without having read all the bytes, Subscription::cancel will be called. >> Whether the subscriber gets unregistered or not at that point becomes racy. >> >> Indeed, the reactive stream specification doesn't guarantee whether >> onComplete or onError will be called or not after a subscriber cancels its >> subscription. Any cleanup that would have been performed by >> onComplete/onError might therefore need to be performed when the >> subscription is cancelled too. > > Daniel Fuchs has updated the pull request incrementally with one additional > commit since the last revision: > > More cleanup to the test src/java.net.http/share/classes/jdk/internal/net/http/common/HttpBodySubscriberWrapper.java line 71: > 69: } > 70: > 71: class SubscriptionWrapper implements Subscription { Perhaps this can be made `private` class? src/java.net.http/share/classes/jdk/internal/net/http/common/HttpBodySubscriberWrapper.java line 181: > 179: if (completed.get()) { > 180: if (subscription != null) { > 181: subscription.subscription.cancel(); Are we intentionally accessing and cancelling the underlying subscription here, instead of the wrapper? Do we intentionally want to bypass the on-cancellation logic in this flow? ------------- PR: https://git.openjdk.org/jdk/pull/10659
