On Fri, 25 Nov 2022 13:23:30 GMT, Michal Karm Babacek <[email protected]> wrote:
>> Hello @Karm, to officially initiate a review of this change, the review >> process (backed by bots) requires a JBS issue to be created and linked >> against this PR. I have created https://bugs.openjdk.org/browse/JDK-8297609 >> to track this. >> >> Next, you will have to update the title of this PR to `8297609: Add >> application/wasm MIME type for wasm file extension` to link this PR against >> that issue. That will then initiate the necessary review process. > > @jaikiran Thanks. Hello @Karm, we have an existing test in the JDK which verifies the expected mime types for some well known extensions. It resides at `test/jdk/java/nio/file/Files/probeContentType/Basic.java`. Could you update that test's main method to include a test for this new mime type that this PR adds? I suspect it would be as simple as adding this new entry to this array here https://github.com/openjdk/jdk/blob/master/test/jdk/java/nio/file/Files/probeContentType/Basic.java#L189 ------------- PR: https://git.openjdk.org/jdk/pull/11284
