On Wed, 30 Nov 2022 16:54:02 GMT, Per Minborg <[email protected]> wrote:
> This PR proposes merging logic and optimising three classes that exist for > aix, maces and windows. > > Optimisation will reduce byte code. Below is an example for one of the many > methods optimised. > > Before: > > public void implCloseSelectableChannel() throws java.io.IOException; > Code: > 0: new #7 // class > java/lang/UnsupportedOperationException > 3: dup > 4: ldc #11 // String SCTP not supported on > this platform > 6: invokespecial #13 // Method > java/lang/UnsupportedOperationException."<init>":(Ljava/lang/String;)V > 9: athrow > > > After: > > public void implCloseSelectableChannel() throws java.io.IOException; > Code: > 0: invokestatic #16 // Method > sun/nio/ch/sctp/UnsupportedUtil.sctpUnsupported:()Ljava/lang/UnsupportedOperationException; > 3: athrow Good to see all the duplication go away. src/jdk.sctp/share/classes/sun/nio/ch/sctp/UnsupportedUtil.java line 1: > 1: package sun.nio.ch.sctp; Still need regular copyright header :-) ------------- PR: https://git.openjdk.org/jdk/pull/11436
