Re: RFR: 8297778: Modernize and improve module jdk.sctp [v5]

[Per Minborg]

On Thu, 1 Dec 2022 10:04:38 GMT, Sergey Tsypanov <stsypa...@openjdk.org> wrote:

>> Per Minborg has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Minor updates
>
> src/jdk.sctp/unix/classes/sun/nio/ch/sctp/ResultContainer.java line 124:
> 
>> 122:             case PEER_ADDRESS_CHANGED -> sb.append("PEER ADDRESS 
>> CHANGE");
>> 123:             case SHUTDOWN             -> sb.append("SHUTDOWN");
>> 124:             default                   -> sb.append("Unknown result 
>> type");
> 
> `->` is misaligned here, I think one more whitespace before it would make it 
> look better

That's what I also thought at first. I double checked in my IDE and there, it 
looks good. Is this a bug in GitHub's rendering?


![image](https://user-images.githubusercontent.com/7457876/205045758-698ebd08-4f44-4e32-827a-de6bb806ef59.png)

also


pminborg@pminborg-mac minborg-jdk % cat 
/Users/pminborg/dev/minborg-jdk/open/src/jdk.sctp/unix/classes/sun/nio/ch/sctp/ResultContainer.java

...

    @Override
    public String toString() {
        StringBuilder sb = new StringBuilder();
        sb.append("Type: ");
        switch (type) {
            case NOTHING              -> sb.append("NOTHING");
            case MESSAGE              -> sb.append("MESSAGE");
            case SEND_FAILED          -> sb.append("SEND FAILED");
            case ASSOCIATION_CHANGED  -> sb.append("ASSOCIATION CHANGE");
            case PEER_ADDRESS_CHANGED -> sb.append("PEER ADDRESS CHANGE");
            case SHUTDOWN             -> sb.append("SHUTDOWN");
            default                   -> sb.append("Unknown result type");
        }
        sb.append(", Value: ");
        sb.append((value == null) ? "null" : value.toString());
        return sb.toString();
    }
}

-------------

PR: https://git.openjdk.org/jdk/pull/11418