On Tue, 6 Jun 2023 07:15:08 GMT, Alan Bateman <[email protected]> wrote:
>> There are cases in the sctp coding where a function
>> sctpHandleSocketErrorWithMessage would be beneficial (similar to existing
>> handleSocketErrorWithMessage) to provide more detail what failed.
>>
>> Additionally sctpHandleSocketErrorWithMessage was a bit modified (added
>> errno handling for ENOTCONN from handleSocketErrorWithMessage).
>
> src/jdk.sctp/unix/native/libsctp/SctpNet.c line 147:
>
>> 145: errno = errorValue;
>> 146: if (message == NULL) {
>> 147: JNU_ThrowByNameWithLastError(env, xn, "NioSocketError");
>
> "NioSocketError" is confusing as the failing message, maybe we should change
> that.
Hi Alan, do you have a good suggestion what to use instead ? Maybe "SCTP socket
error" ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14280#discussion_r1219391449
