On Thu, 8 Jun 2023 14:09:01 GMT, Darragh Clarke <[email protected]> wrote:
>> `HttpURLConnectionExpectContinueTest` was throwing an error due to port
>> being hardcoded, updated test to let the system decide which port to use.
>
> Darragh Clarke has updated the pull request incrementally with one additional
> commit since the last revision:
>
> implemented feedback
test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpectContinueTest.java
line 428:
> 426: URL url = URIBuilder.newBuilder()
> 427: .scheme("http")
> 428: .host(InetAddress.getLoopbackAddress())
This will change the call flow of the test in a slightly subtle way. In the
original the "host" is supplied i.e. localhost which should map to the loopback
address, and in the change the loopback IP address is being supplied diectly.
In terms of equivalence then supplying a host string might be more appropriate:
.host("localhost")
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14177#discussion_r1223122614
