On Sun, 3 Sep 2023 09:16:24 GMT, Vyom Tewari <[email protected]> wrote:
>> With the current implementation of HttpURLConnection if server rejects the >> “Expect 100-continue” then there will be ‘java.net.ProtocolException’ will >> be thrown from 'expect100Continue()' method. >> >> After the exception thrown, If we call any other method on the same instance >> (ex getHeaderField(), or getHeaderFields()). They will internally call >> getOuputStream() which invokes writeRequests(), which make the actual server >> call. >> >> The code change will sets the existing variable ‘rememberedException’ when >> there is exception and getOutputStream0() will re-throw >> ‘rememberedException’ if the ‘rememberedException’ is not null. >> >> Note: getOutputStream0() also call’s ‘expect100Continue()’ if >> ‘expectContinue’ is true. > > Vyom Tewari has updated the pull request incrementally with one additional > commit since the last revision: > > modified the junit tests names test/jdk/java/net/HttpURLConnection/HttpURLConnectionExpect100Test.java line 30: > 28: * getOutputStream > 29: * @library /test/lib > 30: * @run junit/othervm HttpURLConnectionExpect100Test Given the other questions in this PR, I haven't thoroughly reviewed the test, but a quick glance suggested that the `othervm` may not be necessary. Is that right? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15483#discussion_r1314559372
