On Tue, 19 Sep 2023 11:16:11 GMT, Glavo <[email protected]> wrote: >> I mainly made these optimizations: >> >> * Avoid allocating `StringBuilder` when there are no characters in the URL >> that need to be encoded; >> * ~Implement a fast path for UTF-8.~ (Has been removed from this PR) >> >> In addition to improving performance, these optimizations also reduce >> temporary objects: >> >> * It no longer allocates any object when there are no characters in the URL >> that need to be encoded; >> * The initial size of StringBuilder is larger to avoid expansion as much as >> possible; >> * ~For UTF-8, the temporary `CharArrayWriter`, strings and byte arrays are >> no longer needed.~ (Has been removed from this PR) >> >> I also updated the tests to add more test cases. > > Glavo has updated the pull request incrementally with one additional commit > since the last revision: > > Update src/java.base/share/classes/java/net/URLEncoder.java > > Co-authored-by: Claes Redestad <[email protected]>
You need to issue /integrate again since there's been changes since the last time. Re-approval isn't actually required but perhaps it would be good form to pick up that habit. ------------- PR Comment: https://git.openjdk.org/jdk/pull/15354#issuecomment-1725348940 PR Comment: https://git.openjdk.org/jdk/pull/15354#issuecomment-1725356578
