On Fri, 19 Apr 2024 08:28:49 GMT, Daniel JeliĆski <[email protected]> wrote:
> With 800 changed lines in a now-976 file, it's practically a new test :) Yes, in fact it is. đ I refrained from touching the comment table that describes all the possible combinations which make 50% of the file... > Would it make sense to move the system properties to the jtreg run lines? > Like: > > ``` > @run main/othervm KeepAliveTest -Dhttp.keepAlive.time.server=100 c1 > ``` I thought about that, too. I can go that route if you like - the diff will then be even larger and I should also modify the comment table... Shall I? ------------- PR Comment: https://git.openjdk.org/jdk/pull/18817#issuecomment-2066164691
