On Fri, 19 Apr 2024 14:37:27 GMT, robert engels <[email protected]> wrote:
>> Before doing that, you might want to check the HTTPS case. As far as I can >> tell, we don't do any buffering when SSL is in use. > > I think it was safer for future enhancements the way it was done. The other > advantage of using a BAOS over the BOS is that it has better support for > underlying hardware that has large frames (e.g. > 64k) to limit the number of > OS writes. OK - I was just concerned about the additional buffering this implies. Previously we would only buffer as much as the size of the internal BufferedOutputStream buffer. Now we're buffering the whole set of headers until the whole set has been encoded. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1572538401
