On Tue, 23 Apr 2024 08:29:41 GMT, Daniel Jeliński <[email protected]> wrote:
>> robert engels has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "flush after exchange returns"
>>
>> This reverts commit 30340e58be8ae08205400079b055460ed9ac2e25.
>
> test/jdk/com/sun/net/httpserver/bugs/TcpNoDelayNotRequired.java line 83:
>
>> 81: long time = System.currentTimeMillis()-start;
>> 82: System.out.println("time "+time);
>> 83: if(time>5000) throw new IllegalStateException("took too long");
>
> Please drop this line. The timeout will be handled by jtreg, and this line
> makes the test fail on some of our slower CI machines.
Sorry. It returned when I reverted some changes for a test.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1576529549
