Re: RFR: 6968351: httpserver clashes with delayed TCP ACKs for low Content-Length [v21]

[Daniel Fuchs]

On Thu, 25 Apr 2024 15:24:12 GMT, robert engels <d...@openjdk.org> wrote:

>> fix bug JDK-B6968351 by avoiding flush after response headers
>
> robert engels has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   add https testing

src/jdk.httpserver/share/classes/com/sun/net/httpserver/HttpsServer.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2024, Oracle and/or its affiliates. All rights 
> reserved.

Is there a reason for changing the copyright year here? I don't see any other 
change in this file.

src/jdk.httpserver/share/classes/sun/net/httpserver/ChunkedOutputStream.java 
line 145:

> 143:             * calling flush to avoid sending small packets
> 144:             */
> 145:             if(count>0) {

Suggestion:

            if (count > 0) {

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579739244
PR Review Comment: https://git.openjdk.org/jdk/pull/18667#discussion_r1579736689