On Tue, 27 Jan 2026 12:00:44 GMT, Mark Sheppard <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 10 additional >> commits since the last revision: >> >> - merge latest from master branch >> - fix assumption in test >> - merge latest from master branch >> - replace TestAbortedException with Assumptions.assumeTrue >> - skip the test if the SocketChannel unexpectedly connects to the >> destination address >> - rename test to ConnectionRefusedMessage >> - formatting >> - add bug id to the test >> - allow NULL for msg in NET_ThrowNew >> - introduce test > > test/jdk/java/nio/channels/Selector/ConnectionRefusedMessage.java line 108: > >> 106: final InetAddress loopbackAddr = >> InetAddress.getLoopbackAddress(); >> 107: // port 47 is reserved - there should be nothing listening on it >> 108: InetSocketAddress destAddr = new >> InetSocketAddress(loopbackAddr, 47); > > a general comment on the dest port selections below, 47, 51, 61. > These are currently marked as reserved in the IANA port list, but if you look > at the /etc/services file, on macos, you will see that there is a legacy > assignment > > As such, a comment in the test would be useful, such as, > > // using ports 47, 51, 61 from the the IANA reserved port list, which > // are currently unassigned, on the assumption they will not used by > // a listening service Done, I've used your suggestion and updated that comment to be more descriptive. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29409#discussion_r2732676508
