On Wed, 28 Jan 2026 21:01:58 GMT, Sean Mullan <[email protected]> wrote:

>> Artur Barashev has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Force cache limit per compression algorithm
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 979:
> 
>> 977:      * @since 27
>> 978:      */
>> 979:     public void setEnableCertificateCompression(
> 
> Need to specify the default value in the constructor.

The convention in `SSLParameters` is not to specify the default values: the 
rest of set methods in this file don't mention it. In our particular case the 
default value is the value of `jdk.tls.enableCertificateCompression` system 
property, and if such value is not set then it's `true`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28682#discussion_r2739453252

Reply via email to