On Tue, 21 Apr 2026 09:44:13 GMT, Alan Bateman <[email protected]> wrote:
>> Well I've obviously not pushed back changes made during this PR review into >> lworld yet, but those are the only differences, and are not functional. >> lworld has the exploded image logic in and all the plumbing to make the >> compiler stuff work. > > I've done several passes over the changes in this PR. One thing that I'm now > wondering the default (preview features disabled) could work like the raw API > so that META-INF/preview are just resources in the module. It would be like > disable MR processing in the comparison with MR JARs above. When preview > features are enabled then META-INF/preview would overlay as it does now. > Would this allow the side channel that is ResourceEntries go away? This was discussed quite a lot initially in the design phase, and I personally think what we have is the better choice. The "resource entries" are a limited-use mechanism for dealing with the archive file directly, which is a very different domain from the JRT file-system view, in which the "preview mode is like having a different jimage file" model is the easiest to explain. It's also easier to move from this model to the one you're suggesting later (if we feel we need to) than go the other way, if we start by making preview resources visible in any way. Unlike MR Jars, which are a fixed snapshot of some past implementation, what you see in preview mode is going to change as features evolve and things are promoted (or removed) from preview mode. Having any user code care or know what *is* in preview mode *today* is inherently unstable in ways that knowing what *was* in version 3.7 of a library isn't. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29414#discussion_r3116710937
