On Tue, 28 Apr 2026 07:29:38 GMT, Daisuke Yamazaki <[email protected]> wrote:
> Hi all, > > I have migrated these classes to JUnit: > - `jdk/net/ExtendedSocketOption/AsynchronousSocketChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/DatagramChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/DatagramSocketNAPITest.java` > - `jdk/net/ExtendedSocketOption/SocketChannelNAPITest.java` > - `jdk/net/ExtendedSocketOption/SocketNAPITest.java` > > The former `@BeforeTest` has been converted to a static `@BeforeAll`, as this > better reflects the intended scope. > > Additionally, I noticed an issue in the `testSocket` method where > `initialRun` remained `true` for all tests (and conversely remained `false` > in `SocketNAPITest`). > I have corrected this so that the intended consistency check is properly > exercised. > Please let me know if this change introduces any unintended side effects. > > Thanks. > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). test/jdk/jdk/net/ExtendedSocketOption/DatagramChannelNAPITest.java line 104: > 102: initialRun = false; > 103: } else { > 104: assertEquals(receiverID, tempID); I see you've transposed the parameters for assertEquals in many cases (good), there may be a few more that were missed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30964#discussion_r3152341202
