On Fri, 5 Jun 2026 12:03:07 GMT, Volkan Yazici <[email protected]> wrote:
>> EunHyunsu has updated the pull request with a new target base due to a merge >> or a rebase. The pull request now contains six commits: >> >> - fix whitespace issue >> - Merge branch 'master' into JDK-8328894 >> - 8328894: Add test for 407 response body with various handlers >> - 8328894: Cache and return 407 response body to application >> - 8328894: Add proxyResponseBody field to preserve 407 body >> - 8328894: Read 407 response body in HTTPS CONNECT tunneling > > src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 31: > >> 29: import java.net.ProtocolException; >> 30: import java.net.http.HttpClient.Version; >> 31: import java.net.http.HttpHeaders; > > Unused imports. > > I suggest reverting all cosmetic/styling/redundant changes, in particular, > the ones in `PlainTunnelingConnection`. They create noise in the VCS history > and make reviews difficult. Superseded by [this comment](https://github.com/openjdk/jdk/pull/28232#discussion_r3719451162). > src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java line 251: > >> 249: public void cancel() {} >> 250: }); >> 251: return subscriber.getBody().toCompletableFuture(); > > Doesn't this need to be `MinimalFuture.of(subscriber.getBody())`? Superseded by [this comment](https://github.com/openjdk/jdk/pull/28232#discussion_r3719399060). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28232#discussion_r3726511202 PR Review Comment: https://git.openjdk.org/jdk/pull/28232#discussion_r3726512905
