On Tue, 11 Aug 2026 11:38:46 GMT, Daniel Fuchs <[email protected]> wrote:
>> Jaikiran Pai has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - merge latest from master branch
>> - add 8371903 to the test @bug ids
>> - read incomingGoAway just once
>> - 8371903: add test
>> - 8371903: HttpClient: improve handling of HTTP/2 GOAWAY frames with error
>> code
>
> test/jdk/java/net/httpclient/http2/H2GoAwayTest.java line 128:
>
>> 126: () -> client.send(req,
>> BodyHandlers.discarding()));
>> 127: final String actual = ioe.getMessage();
>> 128: if (actual != null &&
>> actual.contains(ioe.getMessage())) {
>
> Should this be:
> `actual.contains(expectedExMsg)` since actual is already ioe.getMessage()?
Good catch, and that's a pretty bad typo. I've updated the PR to fix it. The
test continues to pass with this update. I have triggered a new test repeat run
to be sure that it tests the right thing and there aren't any intermittent
failures.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32278#discussion_r3757712194
