On Tue, 11 Aug 2026 11:53:43 GMT, Jaikiran Pai <[email protected]> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Merge remote-tracking branch 'upstream/master' into hsDrainAmount
>> - Convert `NoContentReturningHandler` to a class
>> - Fix comment on `SocketException("EOF")`
>> - Fix `@bug` tags
>> - Fix the `eof` handling in `FixedLengthInputStream`
>
> test/jdk/com/sun/net/httpserver/property/DrainAmountPropertyTest.java line
> 184:
>
>> 182: if (nextChar < 0) {
>> 183: // Peer disconnect is not expected, escalate it
>> 184: throw new SocketException("EOF");
>
> For debugging purposes, would it better to even print what's been read so
> far? Something like:
>
> if (nextChar < 0) {
> // Peer disconnect is not expected, escalate it
> System.err.println("read so far: " + buffer);
> throw new SocketException("EOF");
Very good idea. Implemented in dda5ee7809d.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32234#discussion_r3764208527
