On Mon, 14 Sep 2026 08:39:33 GMT, Lee Jiwon <[email protected]> wrote:
>> Disable `IP_TOS` support by default in the JDK's default `ServerSocket` >> implementation. Applications can restore support with >> `-Djdk.net.ServerSocket.IP_TOS=true` on the JVM command line. >> >> The `jdk.net.Sockets` option sets are derived from socket instances, >> exposing previously omitted datagram options. `IP_TOS` support on `Socket` >> and `DatagramSocket` is unchanged. >> >> Testing on macOS/aarch64 at `828e5c2b7e76`: >> >> - Affected socket-option tests passed, including five `SupportedOptions` >> configurations. >> - Tier 2 reported five locale failures also seen on baseline, the previously >> observed `UdpTest` timeout, a docs link-check failure due to missing files, >> and a `CreateCoredumpOnCrash` failure due to the core dump limit. >> - `PromiscuousIPv6`, `SSLSocketExplorer`, and `MultiNSTClient` failed or >> timed out in Tier 2; all passed on individual reruns. >> >> Linux and Windows test suites were not run. >> >> Release note: [JDK-8392329](https://bugs.openjdk.org/browse/JDK-8392329) >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Lee Jiwon has updated the pull request incrementally with one additional > commit since the last revision: > > 8392151: Address review comments Unfortunately, the bug history is rather complicated and the rationale for this socket option a bit obscured. It's probably not a common use case to set it on a listening/server socket, but for the case where the TOS field needs to be set during the TCP handshake, it is still useful. We definitely should not remove the option, and I believe disabling it by default may prove a greater nuisance than the benefit from removing it. ------------- PR Comment: https://git.openjdk.org/jdk/pull/32808#issuecomment-5684783307
