On Fri, 18 Sep 2026 09:52:48 GMT, Michael McMahon <[email protected]> wrote:

>> Lee Jiwon has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8392528: Remove unused checkValueType method
>
> src/jdk.net/share/classes/jdk/net/Sockets.java line 266:
> 
>> 264:             }
>> 265:         } catch (IOException e) {
>> 266:             throw new IOError(e);
> 
> Would an UncheckedIOException be better here? IOError is not used anywhere 
> else in the networking code

Updated this to use UncheckedIOException in 
f63dbc17f920a0c447e9ed669d773ee588d456a4. Thanks for the suggestion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/32943#discussion_r4046482639

Reply via email to