On Fri, 25 Sep 2026 20:50:21 GMT, Sean Mullan <[email protected]> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8388484
>> - an example and a more precise spec
>> - a test
>> - the change
>
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 921:
>
>> 919: * parameters are used in SSL/TLS/DTLS connections.
>> 920: * <p>
>> 921: * In TLS 1.3, the ClientHello message can include a list of
>> pre-calculated
>
> Should you also say something like, "For TLS versions earlier than 1.3, group
> names prefixed with an asterisk are treated as if they did not have the
> asterisk"?
I added a sentence into the last paragraph:
* The prefix is ignored when these parameters are used by a server or with
* TLS versions earlier than TLS 1.3.
> src/java.base/share/classes/javax/net/ssl/SSLParameters.java line 926:
>
>> 924: * of the names have the prefix or these names are not available,
>> the
>> 925: * implementation determines which key shares to include in the
>> message.
>> 926: * The prefix is ignored on the server side.
>
> I think it would be useful to add a sentence or two as to when specifying the
> group names using the asterisk form may be useful.
I make it a long example.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/32586#discussion_r4145228462
PR Review Comment: https://git.openjdk.org/jdk/pull/32586#discussion_r4145222156
