On Thu, 8 Oct 2026 10:55:14 GMT, Harald Eilertsen <[email protected]> wrote:
>> The BSD's, like macOS store the SO_LINGER value in a signed short >> internally, so we need to clamp the value to 32767 for all the BSD's, not >> only macOS. >> >> This work is sponsored by The FreeBSD Foundation >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Harald Eilertsen has updated the pull request incrementally with one > additional commit since the last revision: > > Test isBSD in TestMutuallyExclusivePlatformPredicates test/jdk/java/net/Socket/SetSoLinger.java line 26: > 24: /* > 25: * @test > 26: * @bug 4151834 8392732 Suggestion: * @bug 4151834 8392732 8393721 test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java line 2: > 1: /* > 2: * Copyright (c) 2014, 2025, Oracle and/or its affiliates. All rights > reserved. Suggestion: * Copyright (c) 2014, 2026, Oracle and/or its affiliates. All rights reserved. test/lib-test/jdk/test/lib/TestMutuallyExclusivePlatformPredicates.java line 57: > 55: "areCustomLoadersSupportedForCDS", > "isDefaultCDSArchiveSupported", > 56: "isHardenedOSX", "hasOSXPlistEntries", "isOracleLinux7", > "isOnWayland", > 57: "isOpenBSD"); Why is this change necessary? test/lib/jdk/test/lib/Platform.java line 131: > 129: > 130: public static boolean isBSD() { > 131: return osName.toLowerCase().endsWith("bsd"); Suggestion: return osName.toLowerCase(ROOT).endsWith("bsd"); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/33248#discussion_r4219138549 PR Review Comment: https://git.openjdk.org/jdk/pull/33248#discussion_r4219130646 PR Review Comment: https://git.openjdk.org/jdk/pull/33248#discussion_r4219122162 PR Review Comment: https://git.openjdk.org/jdk/pull/33248#discussion_r4219125080
