On Tue, 6 Oct 2026 19:25:33 GMT, Volkan Yazici <[email protected]> wrote:

> Fix port comparison in `java.net.URI::compareTo` and increase the test 
> coverage.
> 
> `open/test/jdk/java/net/URI/Test.java` is improved in following aspects:
> 
> - Old `gt(u, v)` was delegating to `lt(v, u)`. This left `u.compareTo(v) > 0` 
> path unchecked.
> - `eqHashCompUni(u, v)` is introduced to verify all `equals()`, `hashCode()`, 
> `compareTo()` contracts.
> - `eqHashCompBid(u, v)` is introduced to verify `eqHashCompUni(u, v)` 
> bidirectionally.
> 
> ---------
> - [X] I confirm that I make this contribution in accordance with the [OpenJDK 
> Interim AI Policy](https://openjdk.org/legal/ai).

The source change is trivial and looks good to me. I'll need some more time to 
review the test side of these changes because they appear large.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/33232#issuecomment-6082628958

Reply via email to