Hello.

First off I apologize for not having been quicker in my response, I have
been out of touch with my mailbox for a while.

On Fri, May 13, 2005 at 08:55:01AM -0400, Robert Story wrote:
> On Wed, 11 May 2005 23:42:33 +0200 Magnus wrote:
> MF> In include/net-snmp/agent/snmp_agent.h netsnmp_set_request_error and
> MF> netsnmp_set_mode_request_error both have the comment 'deprecated, use
> MF> netsnmp_request_set_error instead'. In agent/snmp_agent.c there is a
> MF> similar comment that points netsnmp_set_all_requests_error to
> MF> netsnmp_request_set_error_all.
> MF> 
> MF> Are the functions really deprecated?
> 
> Not really. Those comments are my wishful thinking. Think of them as
> non-preferred, instead of deprecated.
> 
> MF> Is a patch that performs the substitutions of interest?
> 
> Sure, for cvs main. Not for older branches.

Ok, then the patch that replaces netsnmp_set_all_requests_error with
netsnmp_request_set_error_all is #1210632.

When it comes to netsnmp_set_request_error it have a richer, or at least
different interface than netsnmp_request_set_error.

netsnmp_set_mode_request_error is nt currently used in the netsnmp source.

> MF> The change is not obviously correct as netsnmp_set_request_error have a
> MF> richer interface than netsnmp_request_set_error, but it does not prevent
> MF> the testsuite from running without regressions.
> 
> Did you look at each instance being replaced to see if it seemed correct, or
> just do a quick global search/replace?

Partly, as described above.

/MF


-------------------------------------------------------
This SF.Net email is sponsored by Yahoo.
Introducing Yahoo! Search Developer Network - Create apps using Yahoo!
Search APIs Find out how you can build Yahoo! directly into your own
Applications - visit http://developer.yahoo.net/?fr=offad-ysdn-ostg-q22005
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to