Dave,

I just noticed that you added 4 pointers to the cache_handler structure for
passing handler args to the load routine. This does almost the exact same thing
as the cache hint stuff I added in 5.2. There are two main differences:

1) I added a cache_hint void *, while you added 4 pointers specific types
2) You always set the pointers, while I only set them during the first mode
(GET*, RESERVE1) and iff a flag was set.

I'd like to see if we can't agree on a merging of the two. Well, actually,
since the cache_hint method is already released, it would be more like removing
your version. I don't think competing methods would be a good idea, but you are
welcome to try and convince me.

The one thing I think that would be safe for me to adopt from your method would
be to provide the pointers for every mode (iff the flag was set), instead of
just the first modes. That would hose anyone who might have decided to re-use
that pointer for later modes, but that's probably unlikely and I'm will to
chance it.

I can see that it might be useful to provide the pointers by default, instead
of requiring a flag, but I'm already in the backwards compatibility trap. It
might be reasonable to ignore the flag and always provide the values. That
would only present a backwards compatibility problem for someone who isn't
setting the flag and is expecting to be able to use the cache_hint pointer for
themselves. Dubious, since the possibility isn't advertised, but possible. We
could define a new flag for'reserve cach_hint for user'.

Thoughts?


-- 
Robert Story; NET-SNMP Junkie
Support: <http://www.net-snmp.org/> <irc://irc.freenode.net/#net-snmp>
Archive: <http://sourceforge.net/mailarchive/forum.php?forum=net-snmp-coders>

You are lost in a twisty maze of little standards, all different. 


-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games.  How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.  
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to