Bradford Ritchie wrote:

Instead, I would think that the code should check for the presence of a
parameter (which has already been applied in the @_ assignment), and assign
the corresponding $SNMP:: package variable if the parameter is missing.
There are two places where this is done...


ok - this fix is in cvs if you want to try...

 $this->{UseNumeric} = $SNMP::use_numeric unless
defined($this->{UseNumeric});

instead of this

$this->{UseNumeric} = $SNMP::use_numeric unless exists $this->{UseNumeric};

seems better.

and the following was skipped.

There's also the following code which seems like it would need to be
changed:
 # Force UseLongNames if UseNumeric is in use.
 $this->{UseLongNames}++ if $this->{UseNumeric};

...perhaps to this to keep the two variables in sync:
 # Force UseLongNames if UseNumeric is in use.
 $this->{UseLongNames} = $this->{UseNumeric};


this fix seems wrong as it is possible to have this->{UseLongNames} but not $this->{UseNumeric}, so it is not a direct correlation...just that when $this->{UseNumeric} is true...so must $this->{UseLongNames}.

regards, GSM


-------------------------------------------------------
This SF.Net email is sponsored by the JBoss Inc.  Get Certified Today
Register for a JBoss Training Course.  Free Certification Exam
for All Training Attendees Through End of 2005. For more info visit:
http://ads.osdn.com/?ad_id=7628&alloc_id=16845&op=click
_______________________________________________
Net-snmp-coders mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/net-snmp-coders

Reply via email to