On Mon, 6 Nov 2006 11:12:35 +0000 Dave wrote: DS> > > Way back in February Dave Shield wrote: DS> > > >>> b) Should 'memAvailSwapTXT' and 'memAvailRealTXT' report the DS> > > >>> amount of memory free, or the amount used? DS> > > >>> The MIB object name implies one, the description the other! DS> DS> The latest HAL-based memory module followed the name of the MIB object DS> (thus introducing a change in behaviour for the sole current implementation DS> of these objects). DS> Feedback from IRC indicates that this was seen as inappropriate. DS> DS> I therefore offer the following patch which: DS> - reports the amount of memory used rather than free, DS> - introduces new MIB objects with consistent names/descriptions DS> - deprecates (but retains) the inconsistent MIB objects.
I was under the impression, from a more recent thread, that these were not the only objects that would be a behaviour change from 5.3.x. DS> Index: agent/mibgroup/ucd-snmp/memory.c DS> =================================================================== DS> RCS file: /cvsroot/net-snmp/net-snmp/agent/mibgroup/ucd-snmp/memory.c,v DS> retrieving revision 5.17 DS> diff -u -r5.17 memory.c DS> --- agent/mibgroup/ucd-snmp/memory.c 30 Oct 2006 21:43:28 -0000 5.17 DS> +++ agent/mibgroup/ucd-snmp/memory.c 6 Nov 2006 10:27:55 -0000 DS> - case MEMORY_STXT_AVAIL: /* XXX - Or used ? */ DS> + case MEMORY_STXT_AVAIL: DS> + case MEMORY_STXT_USED: DS> + /* DS> + * The original MIB description of memAvailSwapTXT DS> + * was inconsistent with that implied by the name. DS> + * Retain the actual behaviour for the (sole) DS> + * implementation of this object, but deprecate it in DS> + * favour of a more consistently named replacement object. DS> + */ It would be nice if the comment indicated which of the case labels was the deprecated case. Or maybe add /* deprecated* after the label itself? DS> - case MEMORY_RTXT_AVAIL: /* XXX - Or used ? */ DS> + case MEMORY_STXT_AVAIL: DS> + case MEMORY_STXT_USED: Shouldn't both of these additions be RTXT? And ditto my above comment on the comments. ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 _______________________________________________ Net-snmp-coders mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/net-snmp-coders
