On Tue, Jul 26, 2005 at 09:34:10AM -0500, Jon Wetzel wrote: > This patch gives the e1000 driver the ability to retreive the permanent > hardware address of its device, via the framework established in part 1 > of this patch series. This patch fills in the new perm_addr field on > probing, and implements the get_perm_addr ethtool.
> @@ -1663,6 +1663,13 @@ > } > } > > +static int > +e1000_get_perm_addr(struct net_device *netdev, struct ethtool_addr *eaddr) > +{ > + memcpy(eaddr->addr, netdev->perm_addr, ETH_MAX_ADDR_LEN); > + return 0; > +} > + > struct ethtool_ops e1000_ethtool_ops = { > .get_settings = e1000_get_settings, > .set_settings = e1000_set_settings, This seems pretty generic, especially since you have added perm_addr to the net_device structure. How about if we reform it as ethtool_op_get_perm_addr, so that all drivers can use it? Patch to follow... John P.S. Would a driver ever need to implement its own verion of this function? Since perm_addr is in the net_device structure, is there a cleaner way to do this? Just thinking out-loud... -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html