From: Herbert Xu <[EMAIL PROTECTED]>
Date: Mon, 1 Aug 2005 09:03:14 +1000

> I suspect that the MSS stored in the skb disagrees with the
> mss_now.  So when tso_fragment chops it up we end up with a TSO count
> that's greater than what we started with.

Oh yes, that would bolix things up.  If we get a sequence of
events like this:

        initialize tcp_skb_pcount(skb), but skb cannot be sent
        for some reason

        PMTU event, or addition of SACK blocks, decreases mss_now

        try again to send SKB, whoops it needs fragmenting and
        MSS is different

then that could easily happen.

However, if that actually occurs, cwnd_quota would decrement past zero
in tcp_write_xmit() and hit negative, something we also BUG() on way
before the next tcp_tso_should_defer() call.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to