On 8/6/05, Harald Welte <[EMAIL PROTECTED]> wrote:
> On Sat, Aug 06, 2005 at 11:26:14AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Sat, Aug 06, 2005 at 06:24:35AM -0700, David S. Miller escreveu:
> > > From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo)
> > > Date: Sat, 6 Aug 2005 10:01:05 -0300
> > >
> > > > + /* Be more specific, e.g. net-pf-2-132-1
> > > > (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */
> > > > + if (++try_loading_module == 1)
> > > > + request_module("net-proto-%d-%d-%d", PF_INET,
> > > > protocol, sock->type);
> > >
> > > Your comments don't match the strings you are actually
> > > building in request_module() ie. net-pf-* vs. net-proto-*.
> > > Please make them be consistent.
> >
> > Fixed:
> >
> > rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14.git
> >
> > I checked and the mirrors picked this one already.
>
> I think this is now inconsistent in the way netlink does it:
>
> net/netlink/af_netlink.c:358:
> request_module("net-pf-%d-proto-%d", PF_NETLINK, protocol);
>
> Please either change one or the other. If you decide to change netlink,
> please remember to updating the MODULE_ALIAS_NET_PF_PROTO() macro, too.
Humm, do you have any preference? David? This is something not
exactly to be seen by users as tools extracts the alias from the module, etc,
so I'd say that the way we do in inet_create, i.e. shorter form, is better.
- Arnaldo
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
