[ Cleaning up Cc list ]

On Mon, Aug 08, 2005 at 12:34:00AM +0200, Patrick McHardy wrote:

> > Looking at the latest traces Vladimir sent me, there is another case,
> > too.
> 
> Yes, but nat_packet checks if manips have actually been set up before
> touching the packet. This can never happen for the untracked entry
> because it is initialized with IPS_NAT_DONE_MASK in ip_nat_core.
> I guess we can remove this now:
> 
>         /* Initialize fake conntrack so that NAT will skip it */
>         ip_conntrack_untracked.status |= IPS_NAT_DONE_MASK;

Yes, that is true.  However, we shouldn't push that immediately and test
it before mainline inclusion.  I'm still trying to add a testcase for the
original problem to the nfsim-testsuite, so we can verify the problem is
gone.

-- 
- Harald Welte <[EMAIL PROTECTED]>                      http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

Attachment: pgpsU2siBBsRw.pgp
Description: PGP signature

Reply via email to