* Ralf Baechle <[EMAIL PROTECTED]> 2005-08-12 14:39 > On Fri, Aug 12, 2005 at 02:27:59PM +0100, Ralf Baechle wrote: > > > > Something I noticed doing the tty work. the 6pack driver calls > > > netif_start_queue() before it calls register_netdev. I'm curious if this > > > is allowed ? > > > > As part of adding support for extended 6pack which is required by the > > PR 430 I've recently fixed that. It was looking suspect enough that I > > fixed it though I don't see any way this could do harm. > > To answer the fundamental question, I think netif_start_queue / > netif_stop_queue should be allowed in case the driver for some reason has > the desire to stop queueing of packet immediately after register_netdev.
The statement simply has no effect because the queue cannot be woken up at this point, if so it would be a bug anyway due to uninitialized spinlocks regardless of the prior call to netif_start_queue() so the statement has no effect at all. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
