From: Patrick McHardy <[EMAIL PROTECTED]>
Date: Mon, 15 Aug 2005 16:05:49 +0200
> It was intentional, but I agree the other way around would be more
> consistent. If you want to send a patch, go ahead, otherwise I'll
> put it on my cleanup-list. Not allowing user sockets for unregistered
> protocols allows a couple of other cleanups as well.
I would also like to recommend a few other potential cleanups:
1) inconsistent use of "unsigned int" vs. "u32" for types used
to hold the same data, for example the "groups" member
of nl_table[] (which is "unsigned int") vs. nlk->groups
which is "u32".
2) do_one_set_err() and do_one_broadcast() both make this identical
test:
if (nlk->pid == p->pid || p->group - 1 >= nlk->ngroups ||
!test_bit(p->group - 1, nlk->groups))
goto out;
so, consider making this into an inline function or similar.
But this is nit-picking, of course, your patches were very
well done Patrick :)
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
