On Wed, Aug 17, 2005 at 03:25:30PM -0400, Jeff Garzik wrote:
> >>It's just highly irregular to use pci_unmap_xxx functions immediately 
> >>after calling a pci_map_xxx function.
> >
> >
> >Did you know that pci_unmap_addr_set() is a macro that hides the fact
> >that some arch need iommu but for many it is a no-op. This is the expected 
> >usage.
> >     
> >#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL)              \
> >     (((PTR)->ADDR_NAME) = (VAL))
> 
> Yes, I know.  Think in English.  You use a macro called "unmap" at 
> mapping time.

Complain to davem about the name, Stephen is using it as intended even
if it's misnamed.

-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to