Michael Chan wrote:
David, a set of patches for bnx2 in netdev-2.6.14 will follow. The first
patch fixes a rare rtnl deadlock problem when flush_scheduled_work() is
called in the driver's close function. It looks like this may affect a
number of other drivers as well.
Misc unrelated comments:
* Call netif_rx_schedule() rather than hand-coding the same:
if (netif_rx_schedule_prep(dev)) {
__netif_rx_schedule(dev);
...
if (netif_rx_schedule_prep(dev)) {
__netif_rx_schedule(dev);
* Use IRQ_NONE or IRQ_HANDLED, rather than their IRQ_RETVAL(constant)
equivalents:
return IRQ_RETVAL(1);
...
return IRQ_RETVAL(0);
...
* I really like the fact that basically -nothing- happens in bnx2_msi()
or bnx2_interrupt(). I'm glad to see that all the interrupt processing
occurs from bnx2_poll(). I wish more drivers were written that way.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
