From: Herbert Xu <[EMAIL PROTECTED]>
Date: Fri, 2 Sep 2005 08:11:37 +1000
> On Thu, Sep 01, 2005 at 03:06:47PM -0700, David S. Miller wrote:
> >
> > - if (TCP_SKB_CB(buff)->sacked&TCPCB_LOST) {
> > - tp->lost_out += tcp_skb_pcount(buff);
> > - tp->left_out += tcp_skb_pcount(buff);
> > + tp->packets_out -= diff;
> > + if (diff > 0) {
> > + tp->fackets_out -= diff;
> > + if ((int)tp->fackets_out < 0)
> > + tp->fackets_out = 0;
> > + if (TCP_SKB_CB(skb)->sacked & TCPCB_LOST) {
>
> The TCPCB_LOST stuff should be outside the diff > 0 if block.
Ok.
> > + tp->lost_out -= diff;
> > + if ((int)tp->lost_out < 0)
> > + tp->lost_out = 0;
>
> These checks aren't necessary.
Are you sure this can't happen if the MSS changes?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
