From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Fri, 11 Nov 2005 10:40:42 -0800
> >Are you sure that removing those last two lines are correct? > >Maybe this code is trying to influence the congestion window > >validation engine by updating snd_cwnd_stamp like that. And > >are we sure that the snd_cwnd is always going to be clamped > >properly with the min_t() line removed? If so, maybe it's > >better to BUG() check it, or use WARN_ON(). > > > > > cwnd_stamp is always updated by tcp_cong_avoid (the caller) > so the extra assignment was redundant > > cwnd is already limited by clamp in the slow_start and the > increment code so the min() was redundant Excellent, I'm convinced :) - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html