On 12/22/05, David S. Miller <[EMAIL PROTECTED]> wrote:
> From: Eric Dumazet <[EMAIL PROTECTED]>
> Date: Sat, 17 Dec 2005 11:55:06 +0100
>
> > This patch makes sure a 'struct proto_ops' can be declared as const, so that
> > all cpus can share all parts of it without false sharing.
> ...
> > This should reduce the possibility of false sharing on SMP, and speedup some
> > socket system calls.
> >
> > Signed-off-by: Eric Dumazet <[EMAIL PROTECTED]>
>
> Applied, thanks Eric.
Detected with make allmodconfig
CC [M] drivers/net/pppox.o
/pub/scm/linux/kernel/git/acme/net-2.6.16/drivers/net/pppox.c: In
function 'pppox_create':
/pub/scm/linux/kernel/git/acme/net-2.6.16/drivers/net/pppox.c:125:
error: assignment of read-only member 'ioctl'
make[3]: *** [drivers/net/pppox.o] Error 1
make[2]: *** [drivers/net] Error 2
make[1]: *** [drivers] Error 2
make: *** [_all] Error 2
Command exited with non-zero status 2
static int pppox_create(struct socket *sock, int protocol)
{
int rc = -EPROTOTYPE;
if (protocol < 0 || protocol > PX_MAX_PROTO)
goto out;
rc = -EPROTONOSUPPORT;
if (!pppox_protos[protocol] ||
!try_module_get(pppox_protos[protocol]->owner))
goto out;
rc = pppox_protos[protocol]->create(sock);
if (!rc) {
/* We get to set the ioctl handler. */
/* For everything else, pppox is just a shell. */
sock->ops->ioctl = pppox_ioctl;
}
- Arnaldo
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to [EMAIL PROTECTED]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
