From: Patrick McHardy
Sent: 1/6/2006 5:20:44 PM
> > -static inline void *load_pointer(struct sk_buff *skb, int k,
> > - unsigned int size, void *buffer)
> > +static inline void *load_pointer(struct sk_buff *skb, int k, unsigned int
> > size)
> > {
> > - if (k >= 0)
> > - return skb_header_pointer(skb, k, size, buffer);
> > - else {
> > + if (k >= 0) {
> > + u32 buffer;
> > + return skb_header_pointer(skb, k, size, &buffer);
>
> This is also wrong, now you returning an address from load_pointer's
> stackframe.
So the whole thing is wrong? If so, I guess I understand why it was done the
way it
was before.
Shouldn't gcc warn about this kind of thing?
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
