On Sun, 2006-08-01 at 18:10 +0100, Patrick McHardy wrote: [..] > That discussion had nothing to do with this patch, you actually > already agreed to doing this. Passing double skb pointers is broken: > > > int tcf_action_exec(struct sk_buff *skb, struct tc_action *act, > struct tcf_result *res) > { > ... > ret = a->ops->act(&skb, a, res); > > The caller later continues to use the skb passed to tcf_action_exec > and will crash if it was replaced. >
I am slower that usual today for lack of sleep and travel - can you point me to the discussion or remind me by forwarding me some email? cheers, jamal - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html